-
Notifications
You must be signed in to change notification settings - Fork 57
Refine test coverage #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks goog to me. You have a great readme documentation, so What do you think about to add an entry on it about the feature of uploading the test coverage result as a github artifact? |
Sure, I will try to enhance README.md. I am not good at writing, but I will do my best. I tested the stuff on more project and it looks like
@masch: What do you think? |
I think that the approach that you took is great! I think that you wrote a good explanation on why you decided it and also you gave a good alternative if someone want to use If you let me one more comment please, I know it's none of my business, but I'm 🤓 on git commits history too. As you might know, English is not my first language and I'm sorry if I'm not good enough to just leave a suggestion on this personal comment. |
Thanks a lot for review and feedback. Usually I squash the commits and merge and sometimes just rebase and merge. Depends on the PR 😉 |
Addresses #41
test
make target to get better coverage result and create HTML coverage report